Quick fix for accidentally *fixing* @build deps #2889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In version v0.73.55 we accidentally fixed one half of a bug that previously would not add dependency objects to @build methods of classes. Fixing the other half of the bug would potentially cause behavior changes in image.imports, so this fix simply re-breaks deps generation inside of containers to not cause errors
aksh-at
approved these changes
Feb 21, 2025
|
Would be nice to add a test for this too, but merging this to fix for now. |
|
Yeah I was thinking of adding a test, but also feels a bit wrong to add a test for incorrect behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In version v0.73.55 we accidentally fixed one half of a bug that previously would not add dependency objects to @build methods of classes.
Fixing the other half of the bug, which is that the dependencies are not included in the app layout as provided by the workers seems a bit more involved, so for now this just makes the two dependency lists consistent (but still incorrect, causing image.imports to not work properly in @build functions)
Check these boxes or delete any item (or this section) if not relevant for this PR.
Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.
Changelog