Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed compiling fail of openssl in Debug mode due to non-existed debug folder #85

Open
wants to merge 1 commit into
base: 2.3.x-windows
Choose a base branch
from
Open

fixed compiling fail of openssl in Debug mode due to non-existed debug folder #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions build_openssl.bat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,12 @@ set OPENSSL_TARGETS=out32
if NOT %STATIC_LIBS% (
set OPENSSL_TARGETS=%OPENSSL_TARGETS%dll
)
if NOT %CONFIG_RELEASE% (
set OPENSSL_TARGETS=%OPENSSL_TARGETS%.dbg
)

rem This will trigger build fail since libeay32.lib and ssleay32.lig
rem are not put in this folder in Debug mode
rem if NOT %CONFIG_RELEASE% (
rem set OPENSSL_TARGETS=%OPENSSL_TARGETS%.dbg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So these files are not needed at all? I suppose if you want to debug Mixxx, it is very unlikely you'll need to dig into debugging OpenSSL.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The thing is I have no idea how to build openssl in debug mode. And in the .bat script, even you set Debug, it is actually not built in that way. Probably @rryan can solve the problem.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello.
I've found this also when trying to compile in debug.
I also fixed it on my other PR #87 .

The solution is the same, comment that, since it is incorrect. It is modifying the target when it does not need to.

rem )

copy /b %OPENSSL_TARGETS%\libeay32.lib %LIB_DIR%
copy /b %OPENSSL_TARGETS%\ssleay32.lib %LIB_DIR%
Expand Down