-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed compiling fail of openssl in Debug mode due to non-existed debug folder #85
base: 2.3.x-windows
Are you sure you want to change the base?
Conversation
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
5 similar comments
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
Can one of the admins verify this patch? Say: "add to whitelist" to add this user to the whitelist for future PRs. |
skip ci |
rem This will trigger build fail since libeay32.lib and ssleay32.lig | ||
rem are not put in this folder in Debug mode | ||
rem if NOT %CONFIG_RELEASE% ( | ||
rem set OPENSSL_TARGETS=%OPENSSL_TARGETS%.dbg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So these files are not needed at all? I suppose if you want to debug Mixxx, it is very unlikely you'll need to dig into debugging OpenSSL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing is I have no idea how to build openssl in debug mode. And in the .bat script, even you set Debug, it is actually not built in that way. Probably @rryan can solve the problem.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello.
I've found this also when trying to compile in debug.
I also fixed it on my other PR #87 .
The solution is the same, comment that, since it is incorrect. It is modifying the target when it does not need to.
Our build server doesn't build debug build environments, so can you confirm that you can complete a full debug build locally with this? |
test this please |
The openssl .lib are not put into debug folder in debug mode. Copy those files from debug folder will arise "file not found" errors.