Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Search By ID #752

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Support Search By ID #752

wants to merge 1 commit into from

Conversation

Jellal-HT
Copy link

@Jellal-HT Jellal-HT commented Oct 12, 2021 •
edited
Loading

Signed-off-by: Jellal-HT [email protected]

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jellal-HT
To complete the pull request process, please assign xuanyang-cn after the PR has been reviewed.
You can assign the PR to them by writing /assign @xuanyang-cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@XuanYang-cn
Copy link
Contributor

/cc @bigsheeper

@XuanYang-cn
Copy link
Contributor

/assign @bigsheeper

@Jellal-HT Jellal-HT force-pushed the master branch 2 times, most recently from d2841a3 to bade352 Compare October 19, 2021 20:40
@Jellal-HT Jellal-HT force-pushed the master branch 2 times, most recently from aff21e5 to de20872 Compare October 20, 2021 05:52
@bigsheeper
Copy link
Contributor

/lgtm

@mergify mergify bot added the ci-passed label Oct 20, 2021
XuanYang-cn
XuanYang-cn requested changes Oct 20, 2021
View reviewed changes
pymilvus/client/stub.py Outdated Show resolved Hide resolved
pymilvus/orm/collection.py
Comment on lines +710 to +719
:raises RpcError: If gRPC encounter an error.
:raises ParamError: If parameters are invalid.
:raises DataTypeNotMatchException: If wrong type of param is passed.
:raises BaseException: If the return result from server is not ok.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the right format

@sre-ci-robot sre-ci-robot removed the lgtm label Oct 27, 2021
@sre-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@Jellal-HT Jellal-HT force-pushed the master branch 2 times, most recently from 8b2cd13 to 6934737 Compare October 27, 2021 21:59
@Jellal-HT
Support search by id
f2f4988 
Signed-off-by: Yicheng Hu <[email protected]>
@Jellal-HT Jellal-HT requested a review from XuanYang-cn October 27, 2021 22:31
@XuanYang-cn
Copy link
Contributor

Sorry for the late response.

Could you please update this PR from the master branch? There seems to be a conflict with the latest master branch.

@XuanYang-cn XuanYang-cn mentioned this pull request May 16, 2022
Closed
5 tasks
@mergify mergify bot added the dco-passed label May 19, 2022
@mergify mergify bot added needs-dco and removed dco-passed labels Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@longjiquan longjiquan Awaiting requested review from longjiquan

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@XuanYang-cn XuanYang-cn Awaiting requested review from XuanYang-cn

Requested changes must be addressed to merge this pull request.

Assignees

@bigsheeper bigsheeper

Labels
ci-passed needs-dco size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jellal-HT @sre-ci-robot @XuanYang-cn @bigsheeper