Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Support Search By ID #17029

Closed
1 of 5 tasks
XuanYang-cn opened this issue May 16, 2022 · 4 comments
Closed
1 of 5 tasks

[Feature]: Support Search By ID #17029

XuanYang-cn opened this issue May 16, 2022 · 4 comments
Assignees
Labels
kind/feature Issues related to feature request from users
Milestone

Comments

@XuanYang-cn
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

Currently, We can combine 2 APIs to ack like SearchByID:

  1. vectors = query(expr=f"id in {ids}", output_field=["embeddings"])
  2. search(vectors)

It's inconvenient and inefficient, I'd like an API to directly SearchByID
search(ids)

Some works has been done: #10236, milvus-io/pymilvus#752. I'll start here and redesign, reimplement this feature, follow the below steps:

  • Write design docs of SearchByID
  • Implement SearchByID with UT >= 80%
  • Make SearchByID passing the stability tests
  • Benchmark with the previous 2-APIs way, at the expectation of more efficiency

Describe the solution you'd like.

No response

Describe an alternate solution.

No response

Anything else? (Additional Context)

No response

@XuanYang-cn XuanYang-cn added the kind/feature Issues related to feature request from users label May 16, 2022
@XuanYang-cn XuanYang-cn added this to the 2.2 milestone May 16, 2022
@XuanYang-cn XuanYang-cn self-assigned this May 16, 2022
@stale
Copy link

stale bot commented Jun 15, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jun 15, 2022
@xiaofan-luan
Copy link
Collaborator

keep it open

@stale stale bot removed the stale indicates no udpates for 30 days label Jun 16, 2022
@xiaofan-luan xiaofan-luan modified the milestones: 2.2, 2.3 Nov 24, 2022
@XuanYang-cn
Copy link
Contributor Author

Closing for done

@xiaofan-luan
Copy link
Collaborator

Closing for done

Did we have it already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Issues related to feature request from users
Projects
None yet
Development

No branches or pull requests

2 participants