Refine interfaces for milvus_client #1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold |
yiwen92
reviewed
Jan 8, 2024
czs007
commented
Jan 8, 2024
czs007
commented
Jan 8, 2024
czs007
force-pushed
the
refine_2024
branch
2 times, most recently
from
c4bd7c3 to
607432d
Compare
|
/unhold |
XuanYang-cn
requested changes
Jan 15, 2024
| **kwargs, | ||
| ) -> List[dict]: | ||
| ) -> List[List[dict]]: |
There was a problem hiding this comment.
Please change the Returns in doc
| **kwargs, | ||
| ): | ||
| ) -> Dict: |
There was a problem hiding this comment.
Please change the Returns and Args in doc
|
@czs007 the docstring aren't updated with the methods, please refresh the docstring according to the latest methods. |
XuanYang-cn
requested changes
Jan 15, 2024
czs007
force-pushed
the
refine_2024
branch
2 times, most recently
from
54eb3d4 to
3af370e
Compare
The main focus of this PR is to port some interfaces from ORM and transform them from an object-oriented form to a functional form. As these are new interfaces of MilvusClient, certain parameters and return values have been modified compared to the original ORM interfaces. Signed-off-by: zhenshan.cao <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: czs007, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.