Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix a crash issue of bulkinsert #40331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Fix a crash issue of bulkinsert #40331

wants to merge 1 commit into from
+21 −10

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Mar 4, 2025 •
edited
Loading

issue: #40291
pr: #40304

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 4, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Mar 4, 2025
@dosubot dosubot bot added the severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. label Mar 4, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 4, 2025

@yhmo Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@yhmo yhmo mentioned this pull request Mar 4, 2025
Merged
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.97%. Comparing base (de02a3e) to head (4340ce0).
Report is 27 commits behind head on master.

❌ Your project check has failed because the head coverage (69.97%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40331      +/-   ##
==========================================
+ Coverage   69.88%   69.97%   +0.09%     
==========================================
  Files         309      309              
  Lines       27705    27749      +44     
==========================================
+ Hits        19362    19418      +56     
+ Misses       8343     8331      -12
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.97% <ø> (+0.09%) ⬆️
Go ∅ <ø> (∅)

see 10 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Mar 4, 2025
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 5, 2025
@mergify mergify bot removed the ci-passed label Mar 5, 2025
@yhmo
Copy link
Contributor Author

yhmo commented Mar 5, 2025

rerun ut

@czs007
Copy link
Collaborator

czs007 commented Mar 5, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sre-ci-robot pushed a commit that referenced this pull request Mar 5, 2025
@yhmo
fix: Fix a crash issue of bulkinsert (#40304)
a1b9e3c 
issue: #40291
pr: #40331

Signed-off-by: yhmo <[email protected]>
@yhmo
Copy link
Contributor Author

yhmo commented Mar 6, 2025

rerun ut

1 similar comment
@yhmo
Copy link
Contributor Author

yhmo commented Mar 6, 2025

rerun ut

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 czs007 left review comments

@sunby sunby Awaiting requested review from sunby

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

@czs007 czs007

Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yhmo @czs007 @sre-ci-robot