Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a crash issue of bulkinsert #40304

Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix: Fix a crash issue of bulkinsert #40304

merged 1 commit into from
Mar 5, 2025

Conversation

yhmo
Copy link
Contributor

@yhmo yhmo commented Mar 3, 2025

issue: #40291
pr: #40331

@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Mar 3, 2025
@yhmo yhmo changed the title Fix a crash issue of bulkinsert fix: Fix a crash issue of bulkinsert Mar 3, 2025
Copy link
Contributor

mergify bot commented Mar 3, 2025

@yhmo Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented Mar 3, 2025

@yhmo

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@yhmo yhmo requested a review from bigsheeper March 3, 2025 11:03
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (d754e0b) to head (0ea4b00).
Report is 20 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/util/importutilv2/parquet/util.go 66.66% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #40304      +/-   ##
==========================================
+ Coverage   80.89%   80.91%   +0.01%     
==========================================
  Files        1418     1418              
  Lines      200212   200317     +105     
==========================================
+ Hits       161965   162080     +115     
+ Misses      32577    32564      -13     
- Partials     5670     5673       +3     
Components Coverage Δ
Client 79.28% <ø> (ø)
Core 70.17% <ø> (+0.02%) ⬆️
Go 82.82% <83.33%> (+0.01%) ⬆️
Files with missing lines Coverage Δ
internal/util/importutilv2/parquet/field_reader.go 63.86% <100.00%> (ø)
internal/util/importutilv2/parquet/util.go 71.42% <66.66%> (-0.50%) ⬇️

... and 48 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Mar 4, 2025

@yhmo go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify mergify bot added the ci-passed label Mar 4, 2025
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Mar 5, 2025
@mergify mergify bot removed the ci-passed label Mar 5, 2025
@czs007
Copy link
Collaborator

czs007 commented Mar 5, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, yhmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a1b9e3c into milvus-io:2.5 Mar 5, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants