Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Unify milvus version def #40227

Merged

Conversation

congqixia
Copy link
Contributor

Related to #40216

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Feb 27, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 27, 2025
@dosubot dosubot bot added the go Pull requests that update Go code label Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.53%. Comparing base (b2769fb) to head (952b332).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #40227       +/-   ##
===========================================
+ Coverage   69.85%   80.53%   +10.67%     
===========================================
  Files         309     1473     +1164     
  Lines       27588   206386   +178798     
===========================================
+ Hits        19272   166215   +146943     
- Misses       8316    34144    +25828     
- Partials        0     6027     +6027     
Components Coverage Δ
Client 79.25% <ø> (∅)
Core 69.85% <ø> (ø)
Go 82.32% <ø> (∅)

see 1164 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 27, 2025
@tedxu
Copy link
Contributor

tedxu commented Feb 27, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 35f188b into milvus-io:master Feb 27, 2025
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Feb 27, 2025
Cherry-pick from master
pr: #40227 
Related to #40216

Signed-off-by: Congqi Xia <[email protected]>
@congqixia congqixia deleted the enhance/unify_milvus_version branch February 28, 2025 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. go Pull requests that update Go code kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants