Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] Unify milvus version def #40229

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

congqixia
Copy link
Contributor

Cherry-pick from master
pr: #40227
Related to #40216

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Feb 27, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.90%. Comparing base (bc77bc1) to head (1887136).
Report is 2 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.5   #40229       +/-   ##
===========================================
+ Coverage   70.15%   80.90%   +10.75%     
===========================================
  Files         304     1418     +1114     
  Lines       28274   200188   +171914     
===========================================
+ Hits        19835   161962   +142127     
- Misses       8439    32557    +24118     
- Partials        0     5669     +5669     
Components Coverage Δ
Client 79.28% <ø> (∅)
Core 70.15% <ø> (ø)
Go 82.82% <ø> (∅)

see 1114 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Feb 27, 2025
@tedxu
Copy link
Contributor

tedxu commented Feb 27, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 2f4f594 into milvus-io:2.5 Feb 27, 2025
20 checks passed
@congqixia congqixia deleted the cp25/40227 branch February 28, 2025 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants