Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix flowgraph leak #39656

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

bigsheeper
Copy link
Contributor

@bigsheeper bigsheeper commented Feb 6, 2025

Consider lag targets when determining whether to remove the dispatcher manager.

issue: #39642

Signed-off-by: bigsheeper <[email protected]>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Feb 6, 2025
Copy link
Contributor

mergify bot commented Feb 6, 2025

@bigsheeper Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Feb 6, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 91.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.07%. Comparing base (5669016) to head (b9a56a7).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
pkg/mq/msgdispatcher/client.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39656      +/-   ##
==========================================
- Coverage   80.07%   80.07%   -0.01%     
==========================================
  Files        1464     1464              
  Lines      203311   203319       +8     
==========================================
- Hits       162809   162799      -10     
- Misses      34676    34691      +15     
- Partials     5826     5829       +3     
Components Coverage Δ
Client 79.45% <ø> (ø)
Core 69.39% <ø> (ø)
Go 81.80% <91.66%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
pkg/mq/msgdispatcher/manager.go 96.15% <100.00%> (-2.35%) ⬇️
pkg/mq/msgdispatcher/client.go 95.65% <66.66%> (ø)

... and 23 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Feb 7, 2025

@bigsheeper go-sdk check failed, comment rerun go-sdk can trigger the job again.

@bigsheeper
Copy link
Contributor Author

rerun go-sdk

@mergify mergify bot added the ci-passed label Feb 7, 2025
@czs007
Copy link
Collaborator

czs007 commented Feb 7, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8288c06 into milvus-io:master Feb 7, 2025
19 of 20 checks passed
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Feb 7, 2025
bigsheeper added a commit to bigsheeper/milvus that referenced this pull request Feb 7, 2025
Consider lag targets when determining whether to remove the dispatcher
manager.

issue: milvus-io#39642

Signed-off-by: bigsheeper <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Feb 7, 2025
Consider lag targets when determining whether to remove the dispatcher
manager.

issue: #39642

pr: #39656

Signed-off-by: bigsheeper <[email protected]>
sre-ci-robot pushed a commit that referenced this pull request Feb 8, 2025
Consider lag targets when determining whether to remove the dispatcher
manager.

issue: #39642

pr: #39656

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants