Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [2.4] Fix flowgraph leak #39687

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

bigsheeper
Copy link
Contributor

Consider lag targets when determining whether to remove the dispatcher manager.

issue: #39642

pr: #39656

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Feb 7, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed labels Feb 7, 2025
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.38%. Comparing base (690959a) to head (0533a7c).
Report is 1 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #39687      +/-   ##
==========================================
- Coverage   80.39%   80.38%   -0.01%     
==========================================
  Files        1080     1080              
  Lines      170124   170132       +8     
==========================================
+ Hits       136763   136767       +4     
+ Misses      28845    28842       -3     
- Partials     4516     4523       +7     
Files with missing lines Coverage Δ
pkg/mq/msgdispatcher/client.go 100.00% <100.00%> (ø)
pkg/mq/msgdispatcher/manager.go 98.48% <100.00%> (+2.69%) ⬆️

... and 36 files with indirect coverage changes

@czs007
Copy link
Collaborator

czs007 commented Feb 7, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit d666173 into milvus-io:2.4 Feb 7, 2025
15 checks passed
czs007 pushed a commit that referenced this pull request Feb 10, 2025
fix conflicts from #39687 and
#38916

/kind improvement

Signed-off-by: bigsheeper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants