Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Allow empty sparse row #36061

Merged
merged 1 commit into from
Sep 12, 2024

allow empty sparse row

bb831cd
Select commit
Loading
Failed to load commit list.
Merged

enhance: [2.4]Allow empty sparse row #36061

allow empty sparse row
bb831cd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Sep 12, 2024 in 0s

71.95% (target 77.00%)

View this Pull Request on Codecov

71.95% (target 77.00%)

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (55b33cd) to head (bb831cd).
Report is 24 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36061      +/-   ##
==========================================
- Coverage   71.95%   71.95%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      139344   139341       -3     
==========================================
- Hits       100267   100263       -4     
+ Misses      34815    34793      -22     
- Partials     4262     4285      +23     
Files with missing lines Coverage Δ
internal/core/src/common/Utils.h 61.38% <ø> (-0.38%) ⬇️
internal/core/src/segcore/FieldIndexing.h 22.72% <100.00%> (ø)
pkg/util/typeutil/schema.go 85.98% <100.00%> (+0.14%) ⬆️

... and 34 files with indirect coverage changes