Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.4]Allow empty sparse row #36061

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

zhengbuqian
Copy link
Collaborator

pr: #34700

Signed-off-by: Buqian Zheng <[email protected]>
@sre-ci-robot sre-ci-robot added area/test sig/testing test/integration integration test size/L Denotes a PR that changes 100-499 lines. labels Sep 6, 2024
Copy link
Contributor

mergify bot commented Sep 6, 2024

@zhengbuqian

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Sep 6, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.95%. Comparing base (55b33cd) to head (bb831cd).
Report is 25 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #36061      +/-   ##
==========================================
- Coverage   71.95%   71.95%   -0.01%     
==========================================
  Files        1058     1058              
  Lines      139344   139341       -3     
==========================================
- Hits       100267   100263       -4     
+ Misses      34815    34793      -22     
- Partials     4262     4285      +23     
Files with missing lines Coverage Δ
internal/core/src/common/Utils.h 61.38% <ø> (-0.38%) ⬇️
internal/core/src/segcore/FieldIndexing.h 22.72% <100.00%> (ø)
pkg/util/typeutil/schema.go 85.98% <100.00%> (+0.14%) ⬆️

... and 34 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Sep 6, 2024
@zhengbuqian zhengbuqian changed the title enhance[2.4]: Allow empty sparse row enhance: [2.4]Allow empty sparse row Sep 9, 2024
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed ci-passed do-not-merge/invalid-pr-format labels Sep 9, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Sep 12, 2024
@sre-ci-robot sre-ci-robot merged commit 089790a into milvus-io:2.4 Sep 12, 2024
14 of 15 checks passed
@zhengbuqian zhengbuqian deleted the sparse-allow-empty-2.4 branch September 12, 2024 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants