Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Allow empty sparse row #34700

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #29419

  • If a sparse vector with 0 non-zero value is inserted, no ANN search on this sparse vector field will return it as a result. User may retrieve this row via scalar query or ANN search on another vector field though.
  • If the user uses an empty sparse vector as the query vector for a ANN search, no neighbor will be returned.

@sre-ci-robot sre-ci-robot added area/compilation size/L Denotes a PR that changes 100-499 lines. labels Jul 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 16, 2024
Copy link
Contributor

mergify bot commented Jul 16, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/hold

@zhengbuqian
Copy link
Collaborator Author

/unhold

Copy link
Contributor

mergify bot commented Jul 17, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian zhengbuqian changed the title enhance: Allow empty sparse row; update knowhere commit to latest enhance: Allow empty sparse row Jul 19, 2024
@mergify mergify bot added the ci-passed label Jul 19, 2024
Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.81%. Comparing base (c61592d) to head (c0862ba).
Report is 204 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34700      +/-   ##
==========================================
- Coverage   84.44%   80.81%   -3.63%     
==========================================
  Files         892     1157     +265     
  Lines      117014   141659   +24645     
==========================================
+ Hits        98807   114477   +15670     
- Misses      13836    22813    +8977     
+ Partials     4371     4369       -2     
Files Coverage Δ
internal/core/src/common/Utils.h 89.62% <ø> (ø)
internal/core/src/segcore/FieldIndexing.h 67.25% <100.00%> (ø)
pkg/util/typeutil/schema.go 85.92% <100.00%> (+0.14%) ⬆️

... and 296 files with indirect coverage changes

@wangyiran33
Copy link

hope this feature continues to progress; it's very much needed~~~~

@czs007
Copy link
Collaborator

czs007 commented Aug 16, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot removed the ci-passed label Aug 16, 2024
@sre-ci-robot sre-ci-robot merged commit f4a91e1 into milvus-io:master Aug 16, 2024
11 of 12 checks passed
@zhengbuqian zhengbuqian deleted the sparse-allow-empty branch August 19, 2024 04:18
sre-ci-robot pushed a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation area/test dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants