enhance: add resource group declarative api #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some code should not be merged into sdk. |
chyezh
force-pushed
the
feat_milvus_elastic_serverless_v1
branch
from
e0ef263 to
e8f98a6
Compare
chyezh
force-pushed
the
feat_milvus_elastic_serverless_v1
branch
from
e8f98a6 to
2227ad0
Compare
chyezh
force-pushed
the
feat_milvus_elastic_serverless_v1
branch
from
2227ad0 to
d927743
Compare
- Add UpdateResourceGroups and modify AddResourceGroup api. Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
feat_milvus_elastic_serverless_v1
branch
from
d927743 to
e836ded
Compare
chyezh
changed the title
Signed-off-by: chyezh <[email protected]>
chyezh
force-pushed
the
feat_milvus_elastic_serverless_v1
branch
from
e333af1 to
0016e15
Compare
weiliu1031
reviewed
Apr 15, 2024
| ResourceGroupInfo.Builder builder = ResourceGroupInfo.newBuilder() | ||
| .withResourceGroupName(resourceGroupName) | ||
| .withRequestsNodeNum(resourceGroupInfo.getResourceGroup().getConfig().getRequests().getNodeNum()) | ||
| .withConfig(new ResourceGroupConfig(resourceGroupInfo.getResourceGroup().getConfig())); |
There was a problem hiding this comment.
it's weird to pass rg config and requestNodeNum at same time
There was a problem hiding this comment.
redundant code here, I will remove it.
| .withCollectionName(collection) | ||
| .withSourceGroupName(currentResourceGroupName) | ||
| .withTargetGroupName(resourceGroupName) | ||
| .withReplicaNumber(1L) |
There was a problem hiding this comment.
why just we transfer only one replica to target resource group?
There was a problem hiding this comment.
It's an example. For easy coding, add a single replica limits here.
I will add a comment to explain it.
| if (replicas.getReplicasCount() > 1) { | ||
| // Multi replica is now supported now. | ||
| throw new RuntimeException(String.format("Replica number {} is greater than 1, did not support now", | ||
| replicas.getReplicasCount())); |
There was a problem hiding this comment.
multi replica is supported now
| return null; | ||
| } | ||
|
|
||
| return replicas.getReplicasList().get(0).getResourceGroupName(); |
Signed-off-by: chyezh <[email protected]>
1 task
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, yelusion2 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chyezh
added a commit
to chyezh/milvus-sdk-java
that referenced
this pull request
Apr 18, 2024
…)" This reverts commit 491fe0d. Declarative Resource Group API should not released in 2.4.0. Signed-off-by: chyezh <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 18, 2024
This reverts commit 491fe0d. Declarative Resource Group API should not released in 2.4.0. Signed-off-by: chyezh <[email protected]>
chyezh
added a commit
to chyezh/milvus-sdk-java
that referenced
this pull request
Apr 26, 2024
* enhance: add updates resource group for java sdk - Add UpdateResourceGroups and modify AddResourceGroup api. Signed-off-by: chyezh <[email protected]> * fix: resource group example Signed-off-by: chyezh <[email protected]> * fix: remove redundant code Signed-off-by: chyezh <[email protected]> --------- Signed-off-by: chyezh <[email protected]>
sre-ci-robot
pushed a commit
that referenced
this pull request
Apr 26, 2024
* enhance: add resource group declarative api (#755) * enhance: add updates resource group for java sdk - Add UpdateResourceGroups and modify AddResourceGroup api. Signed-off-by: chyezh <[email protected]> * fix: resource group example Signed-off-by: chyezh <[email protected]> * fix: remove redundant code Signed-off-by: chyezh <[email protected]> --------- Signed-off-by: chyezh <[email protected]> * fix: resource group: dependency lost in example, and support java8 Signed-off-by: chyezh <[email protected]> --------- Signed-off-by: chyezh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: milvus-io/milvus#32282
Add
UpdateResourceGroupsand modifyAddResourceGroupapi.Add example for add resource group declarative api.