Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK]: declarative resource group api #32282

Closed
1 task done
chyezh opened this issue Apr 15, 2024 · 4 comments
Closed
1 task done

[SDK]: declarative resource group api #32282

chyezh opened this issue Apr 15, 2024 · 4 comments
Labels
area/api kind/enhancement Issues or changes related to enhancement
Milestone

Comments

@chyezh
Copy link
Contributor

chyezh commented Apr 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

Latest milvus server support declarative resource group api.
We need all major SDK to support it.

Why is this needed?

  • Add new parameter ResourceGroupConfig into CreateResourceGroup.

  • Add new RPC UpdateResourceGroups.

  • Add new output field in nodes, config in response of DescribeResourceGroup

Anything else?

Milvus server issue: #30647
Milvus proto PR:

Already supported SDK:

@XuanYang-cn @longjiquan @congqixia @yhmo @yelusion2 @shanghaikid @nameczz @czs007

@chyezh chyezh added the kind/enhancement Issues or changes related to enhancement label Apr 15, 2024
@chyezh chyezh added this to the 2.4.1 milestone Apr 15, 2024
sre-ci-robot pushed a commit to milvus-io/pymilvus that referenced this issue Apr 26, 2024
)

issue: milvus-io/milvus#32282
picked from pr: #2002

- Add param `config` for `create_resource_group` api.

- Add `update_resource_groups` api to implement declarative resource
group api.

- Add new example for declarative resource group api.

Signed-off-by: chyezh <[email protected]>
Copy link

stale bot commented May 23, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label May 23, 2024
@chyezh
Copy link
Contributor Author

chyezh commented May 23, 2024

/reopen

@stale stale bot removed the stale indicates no udpates for 30 days label May 23, 2024
sre-ci-robot pushed a commit to milvus-io/milvus-sdk-go that referenced this issue Jun 17, 2024
issue: milvus-io/milvus#32282

- Add UpdateResourceGroups and modify AddResourceGroup api.

- Add example for add resource group declarative api.

---------

Signed-off-by: chyezh <[email protected]>
@chyezh
Copy link
Contributor Author

chyezh commented Jun 17, 2024

all done

@chyezh chyezh closed this as completed Jun 17, 2024
siddarth99 pushed a commit to siddarth99/milvus-sdk-go that referenced this issue Jun 17, 2024
issue: milvus-io/milvus#32282

- Add UpdateResourceGroups and modify AddResourceGroup api.

- Add example for add resource group declarative api.

---------

Signed-off-by: chyezh <[email protected]>
Signed-off-by: Sidharth <[email protected]>
@xiaofan-luan
Copy link
Collaborator

@chyezh can you go through the document see https://milvus.io/docs/resource_group.md#What-is-a-resource-group good anough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api kind/enhancement Issues or changes related to enhancement
Projects
None yet
Development

No branches or pull requests

2 participants