Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: resource group declarative api #243

Merged

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Feb 6, 2024

Related Issue: #244
Related Milvus Issue: milvus-io/milvus#30647

  • Add resource group configuration proto.

  • Add UpdateResourceGroups and modify AddResourceGroup api.

  • Add NodeInfo.

@mergify mergify bot added the dco-passed DCO check passed. label Feb 6, 2024
Copy link

mergify bot commented Feb 6, 2024

@chyezh Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”)

- Add resource group configuration proto.

- Add UpdateResourceGroups and modify AddResourceGroup api.

Signed-off-by: chyezh <[email protected]>
@chyezh chyezh force-pushed the feat_milvus_elastic_serverless branch from 1f63d80 to 527dfcd Compare February 19, 2024 12:09
@jaime0815
Copy link
Contributor

/lgtm

@czs007
Copy link
Collaborator

czs007 commented Feb 20, 2024

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chyezh, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 267686d into milvus-io:master Feb 20, 2024
4 checks passed
@zhengbuqian
Copy link
Contributor

zhengbuqian commented Feb 28, 2024

this seems to be causing some golang tests to fail. in my local go unit test I built milvus using the latest milvus-proto commit on the master branch, and proxy_test.go complains proxyTestServer doesn't have method UpdateResourceGroups.

milvus repo is not yet affected as we haven't bumped the milvus-proto dependency version to include this PR, but once we do go ut will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants