-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: resource group declarative api #243
enhance: resource group declarative api #243
Conversation
@chyezh Please associate the related issue to the body of your Pull Request. (eg. “issue: #6534”) |
4d6c24e
to
1f63d80
Compare
- Add resource group configuration proto. - Add UpdateResourceGroups and modify AddResourceGroup api. Signed-off-by: chyezh <[email protected]>
1f63d80
to
527dfcd
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chyezh, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this seems to be causing some golang tests to fail. in my local go unit test I built milvus using the latest milvus-proto commit on the master branch, and milvus repo is not yet affected as we haven't bumped the milvus-proto dependency version to include this PR, but once we do go ut will fail. |
Related Issue: #244
Related Milvus Issue: milvus-io/milvus#30647
Add resource group configuration proto.
Add UpdateResourceGroups and modify AddResourceGroup api.
Add NodeInfo.