Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linenumbers of links starting with ) ] don't work on terminal #240059

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+1 −1
Open

fix: Linenumbers of links starting with ) ] don't work on terminal #240059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a877469
fix: Linenumbers of links starting with `)` `]` `'` `"` don't work on…
NriotHrreion Feb 8, 2025
71d7ea6
Exclude single quote and double quote from the regex `linkWithSuffixP…
NriotHrreion Feb 8, 2025
6e7ea38
Merge branch 'main' into main
NriotHrreion Feb 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vs/workbench/contrib/terminalContrib/links/browser/terminalLinkParsing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ function parseIntOptional(value: string | undefined): number | undefined {
// characters the path is not allowed to _start_ with, the second `[]` includes characters not
// allowed at all in the path. If the characters show up in both regexes the link will stop at that
// character, otherwise it will stop at a space character.
const linkWithSuffixPathCharacters = /(?<path>(?:file:\/\/\/)?[^\s\|<>\[\({][^\s\|<>]*)$/;
const linkWithSuffixPathCharacters = /(?<path>(?:file:\/\/\/)?[^\s\|<>\[\]\(\){][^\s\|<>]*)$/;

export function detectLinks(line: string, os: OperatingSystem) {
// 1: Detect all links on line via suffixes first
Expand Down