Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linenumbers of links starting with ) ] don't work on terminal #240059

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

NriotHrreion
Copy link
Contributor

@NriotHrreion NriotHrreion commented Feb 8, 2025

fix #231998

This regex doesn't include ) ] as characters paths are not allowed to start with.

const linkWithSuffixPathCharacters = /(?<path>(?:file:\/\/\/)?[^\s\|<>\[\({][^\s\|<>]*)$/;

@NriotHrreion NriotHrreion changed the title fix: Linenumbers of links starting with ) ] ' " don't work on terminal fix: Linenumbers of links starting with ) ] don't work on terminal Feb 8, 2025
@NriotHrreion
Copy link
Contributor Author

NriotHrreion commented Feb 8, 2025

Initially, I included single quote ' and double quote " into the regex. But I found it left the relevant tests not passed.
So I removed them from the regex in 71d7ea6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link with :lineNumber didn't work on Terminal
2 participants