Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue217 - Rollback transaction in CreateInstance stored proc to prevent deadlocks #218

Merged
merged 2 commits into from
May 7, 2024
+2 −0
Merged

Issue217 - Rollback transaction in CreateInstance stored proc to prevent deadlocks #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f560737
Issue217 - Rollback transaction before throwing error when an orchest…
May 7, 2024
18f8bf6
Update CHANGELOG.md
cgillum May 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Updates

* Replace hardcoded version string + globs with build variables ([#213](https://github.com/microsoft/durabletask-mssql/pull/213))
* Fix deadlock issue on orchestration creation ([#218](https://github.com/microsoft/durabletask-mssql/pull/218)) - contributed by [@microrama](https://github.com/microrama)

## v1.2.3

Expand Down
1 change: 1 addition & 0 deletions src/DurableTask.SqlServer/Scripts/logic.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,6 +260,7 @@ BEGIN
IF @existingStatus IN (SELECT value FROM STRING_SPLIT(@DedupeStatuses, ','))
BEGIN
DECLARE @msg nvarchar(4000) = FORMATMESSAGE('Cannot create instance with ID ''%s'' because a pending or running instance with ID already exists.', @InstanceID);
ROLLBACK TRANSACTION;
THROW 50001, @msg, 1;
END
ELSE IF @existingStatus IS NOT NULL
Expand Down
Loading