Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue217 - Rollback transaction in CreateInstance stored proc to prevent deadlocks #218

Merged
merged 2 commits into from
May 7, 2024

Conversation

microrama
Copy link
Contributor

Issue217 - Rollback transaction before throwing error when an orchestration instance has already been created by another process/thread. This is to prevent deadlocks as explained in the issue.

…ration instance has already been created by another process/thread.

This is to prevent deadlocks as explained in the issue.
@microrama
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="{MTB}"]

@microrama
Copy link
Contributor Author

@microsoft-github-policy-service agree
@microsoft-github-policy-service agree company="MTB"

@bhugot
Copy link
Contributor

bhugot commented May 7, 2024

I didn t had the time today but did you check that was the only case?

@cgillum cgillum merged commit a9a1a71 into microsoft:main May 7, 2024
2 checks passed
bhugot pushed a commit to bhugot/durabletask-mssql that referenced this pull request May 7, 2024
@microrama microrama deleted the Fix217 branch May 23, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dt.CreateInstance stored proc is causing deadlocks (proposed ROLLBACK change that fixes the issue)
3 participants