Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail faster in checkTokens #17

Closed
wants to merge 2 commits into from
Closed

Fail faster in checkTokens #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fab7a3a
fail fast on checking tokens
jonchurch Apr 22, 2024
3aba916
fix formatting, add explicit return type
jonchurch Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions packages/ado-npm-auth/src/npmrc/check-tokens.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,29 +9,26 @@ import { getUserNPMRC } from "./npmrc.js";
* @param { boolean } [options.silent]
* @param { Array<NpmrcOrg> } [options.feeds]
*/
export const checkTokens = async function ({ feeds }: { feeds: NpmrcOrg[] }) {
export const checkTokens = async function ({ feeds }: { feeds: NpmrcOrg[] }): Promise<boolean> {
jonchurch marked this conversation as resolved.
Show resolved Hide resolved
const userNpmRc = getUserNPMRC();

const feedsWithPat = await getUserPat({ npmrc: userNpmRc, feeds });

const missingPats = feedsWithPat.filter((item) => !item.pat);

if (missingPats.length) {
return false
return false;
}

try {
// check each feed for validity
for (const feed of feedsWithPat) {
await makeADORequest({
password: feed.pat || "",
await Promise.all(feedsWithPat.map(feed =>
makeADORequest({
password: feed.pat ?? "",
organization: feed.organization,
});
}

})
jonchurch marked this conversation as resolved.
Show resolved Hide resolved
));
return true;
} catch (e) {
return false;
}

return true;
};
Loading