Fail faster in checkTokens
#17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchurch
force-pushed
the
jonchurch/pat-check-perf
branch
from
679b7cf to
fab7a3a
Compare
|
Edit: blegh, I haven't been able to find a way to parse the token expiry. I thought I'd done this in the past, the same way you can with a JWT, but Im not finding satisfaction this time. I stand by this change, but interestingly we may also be able to parse the token to check its expiry, so we can fail even faster w/o a network request. We'd still want to verify via network, but if we can fail even faster on good confidence the network request won't work bc token expiration, then that's awesome. |
jcreamer898
approved these changes
Apr 22, 2024
jcreamer898
requested changes
Apr 22, 2024
| } | ||
|
|
||
| }) | ||
| )) |
jonchurch
commented
Apr 22, 2024
|
Requested changes have been made! The token parsing to check expiry locally isn't possible rn from what I have seen. |
|
underlying file was deleted, logic is largely the same but closing since I don't plan to update this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the code to check tokens will return
falseif any of the tokens we detect fail the network request.But we are still doing sequential network calls to check that.
This PR goes full fail fast via
Promise.alland returns false if we rejectIs it faster? For most people, prolly not
¯\_(ツ)_/¯but if a user has several tokens (like I do) but only the last of 10 is bad, it should give us a faster result.