Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permissions for dynamically created frames #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TiborUdvari
Copy link

Some online editors, such as the p5.js web editor, create dynamic iframes that don't match the URL of the parent, as I tried to explain in #64. The permission change in this PR enables the polyfill in these contexts. Here is the related documentation.

I setup a minimal example with the barebones-ar immersive example [here] to validate it working. (https://editor.p5js.org/TiborUdvari/sketches/zW9qJtK7V).

I thought that having the permission in the script injected by the service worker would be enough, but through some trial and error I found this is the minimal permission change to make it work. For future reference, there is also a match_about_blank permission that might be needed in some cases, although not mine.

Here, it is working in the editor after the changes.

Screenshot 2024-08-26 at 14 36 25

@facebook-github-bot
Copy link
Contributor

Hi @TiborUdvari!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants