Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: made footer icons clickable again #195

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Conversation

chapati23
Copy link
Contributor

@chapati23 chapati23 commented Feb 18, 2025

Description

footer icons were covered by the bottom grid graphic

simplest solution I found was to simply make the bottom-grid pass through all clicks to the below elements effectively making it invisible to the mouse/trackpad but still visible visually

How to test

  1. Check app.mento.org and try to click the footer icons, see it fail
  2. Check the preview URL of this branch, and see that footer icons are clickable again

Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mento-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 18, 2025 5:14pm

Copy link
Contributor

@Andrew718PLTS Andrew718PLTS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks and works fine, all the buttons are available to click without a crashing.

Copy link
Contributor

@nvtaveras nvtaveras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview looks good!

@chapati23 chapati23 merged commit c73d67f into main Feb 18, 2025
7 of 8 checks passed
@chapati23 chapati23 deleted the fix/footer-icons-unclickable branch February 18, 2025 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants