Skip to content

Commit

Permalink
fix: made footer icons clickable again (#195)
Browse files Browse the repository at this point in the history
### Description

footer icons were covered by the bottom grid graphic

simplest solution I found was to simply make the bottom-grid pass
through all clicks to the below elements effectively making it invisible
to the mouse/trackpad but still visible visually


### How to test

1. Check app.mento.org and try to click the footer icons, see it fail
2. Check the preview URL of this branch, and see that footer icons are
clickable again
  • Loading branch information
chapati23 authored Feb 18, 2025
1 parent fdc248d commit c73d67f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 20 deletions.
41 changes: 22 additions & 19 deletions .github/workflows/check-branch.yml
Original file line number Diff line number Diff line change
@@ -1,21 +1,24 @@
name: Prevent Non-Release/Non-Hotfix PRs to Main
# NOTE: @chapati23 disabled this check today on 18.02.2025 as a conscious tradeoff to prioritize simpler and faster delivery
# over a slower release cycle with more checks. We can turn it back on if we notice that we have more production issues but
# for the moment we don't have a lot of users on this DApp so should prioritize faster improvements until we reach greater scale.

on:
pull_request:
branches:
- main
pull_request_target:
branches:
- main
# name: Prevent Non-Release/Non-Hotfix PRs to Main
# on:
# pull_request:
# branches:
# - main
# pull_request_target:
# branches:
# - main

jobs:
check-target-branch:
if: github.base_ref == 'main'
runs-on: ubuntu-latest
steps:
- name: Check if the source branch is a release branch
run: |
if [[ "${{ github.head_ref }}" != release/* && "${{ github.head_ref }}" != hotfix/* ]]; then
echo "Only release and hotfix branches can be merged into the main branch."
exit 1
fi
# jobs:
# check-target-branch:
# if: github.base_ref == 'main'
# runs-on: ubuntu-latest
# steps:
# - name: Check if the source branch is a release branch
# run: |
# if [[ "${{ github.head_ref }}" != release/* && "${{ github.head_ref }}" != hotfix/* ]]; then
# echo "Only release and hotfix branches can be merged into the main branch."
# exit 1
# fi
2 changes: 1 addition & 1 deletion src/components/nav/BottomGrid.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import BackgroundTiles from 'src/images/background/background_tiles_light.png'

export function BottomGrid() {
return (
<div className="absolute bottom-0 z-10 transform -translate-x-1/2 left-1/2">
<div className="absolute bottom-0 transform -translate-x-1/2 left-1/2 pointer-events-none">
<div className="w-screen h-[201px] relative">
<Image
src={BackgroundTiles}
Expand Down

0 comments on commit c73d67f

Please sign in to comment.