-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: made footer icons clickable again (#195)
### Description footer icons were covered by the bottom grid graphic simplest solution I found was to simply make the bottom-grid pass through all clicks to the below elements effectively making it invisible to the mouse/trackpad but still visible visually ### How to test 1. Check app.mento.org and try to click the footer icons, see it fail 2. Check the preview URL of this branch, and see that footer icons are clickable again
- Loading branch information
Showing
2 changed files
with
23 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,24 @@ | ||
name: Prevent Non-Release/Non-Hotfix PRs to Main | ||
# NOTE: @chapati23 disabled this check today on 18.02.2025 as a conscious tradeoff to prioritize simpler and faster delivery | ||
# over a slower release cycle with more checks. We can turn it back on if we notice that we have more production issues but | ||
# for the moment we don't have a lot of users on this DApp so should prioritize faster improvements until we reach greater scale. | ||
|
||
on: | ||
pull_request: | ||
branches: | ||
- main | ||
pull_request_target: | ||
branches: | ||
- main | ||
# name: Prevent Non-Release/Non-Hotfix PRs to Main | ||
# on: | ||
# pull_request: | ||
# branches: | ||
# - main | ||
# pull_request_target: | ||
# branches: | ||
# - main | ||
|
||
jobs: | ||
check-target-branch: | ||
if: github.base_ref == 'main' | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Check if the source branch is a release branch | ||
run: | | ||
if [[ "${{ github.head_ref }}" != release/* && "${{ github.head_ref }}" != hotfix/* ]]; then | ||
echo "Only release and hotfix branches can be merged into the main branch." | ||
exit 1 | ||
fi | ||
# jobs: | ||
# check-target-branch: | ||
# if: github.base_ref == 'main' | ||
# runs-on: ubuntu-latest | ||
# steps: | ||
# - name: Check if the source branch is a release branch | ||
# run: | | ||
# if [[ "${{ github.head_ref }}" != release/* && "${{ github.head_ref }}" != hotfix/* ]]; then | ||
# echo "Only release and hotfix branches can be merged into the main branch." | ||
# exit 1 | ||
# fi |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters