Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tidy] Add CSS for new DatePickerInput #959

Merged
merged 25 commits into from
Jan 20, 2025
Merged

[Tidy] Add CSS for new DatePickerInput #959

merged 25 commits into from
Jan 20, 2025

Conversation

huong-li-nguyen
Copy link
Contributor

@huong-li-nguyen huong-li-nguyen commented Jan 20, 2025

Description

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

Copy link
Contributor

github-actions bot commented Jan 20, 2025

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2025-01-20 14:14:22 UTC
Commit: 69e55c8

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

@huong-li-nguyen huong-li-nguyen marked this pull request as ready for review January 20, 2025 14:16
@antonymilne
Copy link
Contributor

FYI @huong-li-nguyen in #960 I decided in the end to not fix the order of the mantine_dates.css in any particular way. Hence it's just served in alphabetical order like all our other CSS (with the exception of vizro-bootstrap.css which is always first). This means that currently mantine_dates.css is served before datepicker.css, but if we change the names of these files in future then that could change.

Copy link
Contributor

@antonymilne antonymilne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome, thank you @nadijagraca, @huong-li-nguyen and @AnnMarieW 🚀

@huong-li-nguyen huong-li-nguyen merged commit 5d21dc9 into main Jan 20, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants