-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add css for DatePicker component #1
base: dmc-15
Are you sure you want to change the base?
Conversation
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: huong-li-nguyen <[email protected]>
Co-authored-by: huong-li-nguyen <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: joseph_perkins <[email protected]>
Co-authored-by: Maximilian Schulz <[email protected]>
Hey @nadijagraca - great job getting this done! ✨ I've added a bit more CSS as the hover states were missing. The styling of actively selected month / date doesn't seem to be supported anymore, as the component are not marked as "active". Hence, we can also add no styling for that. I don't think it's that bad though. So for me it's ready to merge 👍 I've also added a global font family for all dmc components. |
This looks nice! It's not necessary to make updates to this unless other issues are addressed in the PR. But if this looks like it might get merged then I have just a couple comments:
This would make is to that it's a better match to the Vizro theme if people add other custom Mantine components. Otherwise those components will have the default blue accent color.
|
Hey @AnnMarieW, Thank you for your comments! We've now implemented all your suggestions 👍. Initially, we used selectors like I've now applied I think you would have to click on the merge button for us @AnnMarieW, as we don't have push/write access to your fork :) |
Signed-off-by: Li Nguyen <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Li Nguyen <[email protected]> Co-authored-by: Antony Milne <[email protected]>
This is superseded by mckinsey#959. |
Description
Added css for DatePicker component.
To do:
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":