Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video length and storage quota increase #33

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mobile/src/main/java/com/opendashcam/Util.java
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,9 @@ public final class Util {
private static final String NOTIFICATIONS_CHANNEL_ID_MAIN_NOTIFICATIONS = "1001";
private static final String NOTIFICATIONS_CHANNEL_NAME_MAIN_NOTIFICATIONS = "Main notifications";

private static int QUOTA = 1000; // megabytes
private static int QUOTA_WARNING_THRESHOLD = 200; // megabytes
private static int MAX_DURATION = 45000; // 45 seconds
private static int QUOTA = 3000; // megabytes
private static int QUOTA_WARNING_THRESHOLD = 500; // megabytes
private static int MAX_DURATION = 600000; // 10 minutes
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the duration per video clip.
Some devices may have trouble recording longer video clips. For example, https://9to5google.com/2021/08/30/pixel-5a-overheating-issues-google/

Pixel 5a would stop recording after about 4 minutes of recording 4K video with heat as the cause

thus we keep the individual snippets as short as possible.


public static File getVideosDirectoryPath() {
//remove an old directory if exists
Expand Down