Video length and storage quota increase #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxneaga
reviewed
Oct 3, 2021
There was a problem hiding this comment.
Thank you, @JirkaKuba , for opening this PR.
I am wondering what was the reasoning behind this delivery? I am only guessing to store more footage as the device capacities have increased over the past couple of years.
| private static int MAX_DURATION = 45000; // 45 seconds | ||
| private static int QUOTA = 3000; // megabytes | ||
| private static int QUOTA_WARNING_THRESHOLD = 500; // megabytes | ||
| private static int MAX_DURATION = 600000; // 10 minutes |
There was a problem hiding this comment.
This is the duration per video clip.
Some devices may have trouble recording longer video clips. For example, https://9to5google.com/2021/08/30/pixel-5a-overheating-issues-google/
Pixel 5a would stop recording after about 4 minutes of recording 4K video with heat as the cause
thus we keep the individual snippets as short as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.