Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a files catalog #4913

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

create a files catalog #4913

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0df7591
create a files catalog
olga-wukelan Dec 9, 2024
71cf361
fix comments to catalog
olga-wukelan Dec 10, 2024
40ce3a0
fix comment to card
olga-wukelan Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Create an HTML page with a catalog. Develop semantic page structure as shown on
- add `data-qa="card-hover"` (not just `hover`) to the link `Buy` inside the first card
- nav links color is not `black` anymore (nav links should have `#060b35` color)
- add the class `is-active` to the first link (`Apple`) in the navigation
- use `<main>` tag for cards container
- use `<main>` tag for cards container
- use the grid for cards with different numbers of columns:
- 1 for the smaller screens
- 2 starting at `488px`
Expand All @@ -32,9 +32,9 @@ This is possible because [we use the Parcel library](https://en.parceljs.org/scs

## Checklist

❗️ Replace `<your_account>` with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://<your_account>.github.io/layout_catalog/)
- [TEST REPORT LINK](https://<your_account>.github.io/layout_catalog/report/html_report/)
❗️ Replace `<your_account>`with your GitHub username and copy the links to the `Pull Request` description:
- [DEMO LINK](https://olga-wukelan.github.io/layout_catalog/)
- [TEST REPORT LINK](https://olga-wukelan.github.io/layout_catalog/report/html_report/)

❗️ Copy this `Checklist` to the `Pull Request` description after links, and put `- [x]` before each point after you checked it.

Expand Down
354 changes: 352 additions & 2 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
<!doctype html>
<html lang="en">
<!-- #region head -->
<head>
<meta charset="UTF-8" />
<meta
Expand All @@ -17,11 +18,360 @@
/>
<link
rel="stylesheet"
href="styles/index.scss"
href="./index.scss"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The stylesheet is linked as index.scss, which is not directly usable by browsers. Ensure that this SCSS file is compiled to CSS and the correct CSS file is linked here.

/>
</head>
<!-- endregion -->

<body>
<h1>Catalog</h1>
<!-- #region header -->
<header class="header">
<a
href="#"
class="header__logo"
>
<img
src="./images/logo.png"
alt="Moyo Logo"
/>
</a>

<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="is-active nav__link"
>
apple
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
samsung
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
smartphones
</a>
</li>
<li class="nav__item">
<a
href="#"
data-qa="nav-hover"
class="nav__link"
>
laptops & computers
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
gadgets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
tablets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
photo
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
video
</a>
</li>
</ul>
</nav>
</header>
<!-- #endregion -->
<main class="main">
<!-- #region card 1 -->
<div
class="card"
data-qa="card"
>
<img
class="card__image"
src="../src/images/imac.jpeg"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image source path ../src/images/imac.jpeg might not be correct depending on your file structure. Ensure the path is correct relative to the HTML file location.

alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This tag used for title of the full page, consider will be better if you use the another tag here. Fix it everywhere

Suggested change
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<h2 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h2>

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я не розуміюю. у мене це ж і є основним заголовком до карти. чи мається на увазі, що всі карти це другорядні на сторінці і може бути заголовок до блоку каталогу? @volodymyr-soltys97

<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button
class="card__button"
data-qa="card-hover"
>
buy
</button>
</div>
<!-- #endregion -->
<!-- #region card 2-->
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 3-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 4-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 5-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 6-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 7-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
<!-- #region card 8-->
<div class="card">
<img
class="card__image"
src="../src/images/imac.jpeg"
olga-wukelan marked this conversation as resolved.
Show resolved Hide resolved
alt="imac"
/>
<h1 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h1>
<p class="card__code">Product code: 195434</p>
<!-- #region stars -->

<div class="card__reviews-block">
<div class="stars stars--4">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>
<p class="card__reviews">Reviews: 5</p>
</div>

<!-- #endregion -->
<div class="card__value">
<p class="card__price">Price:</p>
<p class="card__price-number">$2,199</p>
</div>
<button class="card__button">buy</button>
</div>
<!-- #endregion -->
</main>
</body>
</html>
Loading
Loading