create a files catalog #4913
create a files catalog #4913
Conversation
olga-wukelan
commented
Dec 9, 2024
olga-wukelan
commented
- DEMO LINK
- TEST REPORT LINK
There was a problem hiding this comment.
Thank you for your hard work on this project! There are a few critical issues that need to be addressed before we can approve the pull request:
-
Variable Typos: There's a typo in the SCSS variable name
$font-weigth-bold. It should be$font-weight-bold. This needs to be corrected to ensure styles are applied correctly. -
Missing Variable Definitions: Ensure that variables like
$main-color,$primary-color, and$secondary-colorare defined in your variables file. Missing definitions can lead to compilation errors. -
Incorrect Selector: The selector
&__button:hoveris incorrect. It should be&:hoverto apply the hover effect on the button itself. -
File Path Issues: Verify that all image paths and SCSS import paths are correct. Incorrect paths can lead to missing styles or images.
-
SCSS Compilation: The stylesheet is linked as
index.scss, which browsers cannot use directly. Ensure this SCSS file is compiled to CSS and the correct CSS file is linked.
Once these issues are resolved, your code will be in great shape! Keep up the great work, and feel free to reach out if you have any questions. 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.
src/index.html
Outdated
| @@ -17,11 +18,360 @@ | |||
| /> | |||
| <link | |||
| rel="stylesheet" | |||
| href="styles/index.scss" | |||
| href="./index.scss" | |||
There was a problem hiding this comment.
The stylesheet is linked as index.scss, which is not directly usable by browsers. Ensure that this SCSS file is compiled to CSS and the correct CSS file is linked here.
src/index.html
Outdated
| > | ||
| <img | ||
| class="card__image" | ||
| src="../src/images/imac.jpeg" |
There was a problem hiding this comment.
The image source path ../src/images/imac.jpeg might not be correct depending on your file structure. Ensure the path is correct relative to the HTML file location.
src/styles/navigation.scss
Outdated
|
|
||
| .is-active { | ||
| position: relative; | ||
| color: $main-color; |
There was a problem hiding this comment.
Ensure that the variable $main-color is defined in your variables file. If it's not defined, this will cause a compilation error.
src/styles/navigation.scss
Outdated
| display: block; | ||
| content: ''; | ||
| border-radius: 8px; | ||
| background-color: $main-color; |
There was a problem hiding this comment.
Ensure that the variable $main-color is defined in your variables file. If it's not defined, this will cause a compilation error.
src/styles/stars.scss
Outdated
| margin-right: 4px; | ||
| background-repeat: no-repeat; | ||
| background-position: center; | ||
| background-image: url(./images/star.svg); |
There was a problem hiding this comment.
Ensure that the image path './images/star.svg' is correct and the file exists at the specified location.
src/index.html
Outdated
| <h1 class="card__title"> | ||
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | ||
| </h1> |
There was a problem hiding this comment.
This tag used for title of the full page, consider will be better if you use the another tag here. Fix it everywhere
| <h1 class="card__title"> | |
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | |
| </h1> | |
| <h2 class="card__title"> | |
| APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A) | |
| </h2> |
There was a problem hiding this comment.
я не розуміюю. у мене це ж і є основним заголовком до карти. чи мається на увазі, що всі карти це другорядні на сторінці і може бути заголовок до блоку каталогу? @volodymyr-soltys97
src/styles/index.scss
Outdated
| @@ -1,3 +1,13 @@ | |||
| body { | |||
| margin: 0; | |||
| font-family: Roboto, sans-serif; | |||
| font-weight: 400; | |||
| color: #060b35; | |||
There was a problem hiding this comment.
| color: #060b35; |
