Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog #4906

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Catalog #4906

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d57965
Catalog
taniaPya Dec 7, 2024
7a7bb9a
Catalog fixed
taniaPya Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
375 changes: 375 additions & 0 deletions src/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,380 @@

<body>
<h1>Catalog</h1>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<h1>Catalog</h1>

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed
image


<header>
<div class="logo">
<a
href="#"
class="logo__link"
>
<img
src="images/logo.png"
alt="Company Logo"
/>
</a>
</div>

<nav class="nav">
<ul class="nav__list">
<li class="nav__item">
<a
href="#"
class="nav__link is-active"
>
apple
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
samsung
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
smartphones
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
data-qa="nav-hover"
>
laptops & computers
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
gadgets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
tablets
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
photo
</a>
</li>
<li class="nav__item">
<a
href="#"
class="nav__link"
>
video
</a>
</li>
</ul>
</nav>
</header>

<main class="catalog">
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>
<h3 class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</h3>

Consider leveraging semantic tags

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fixed


<div class="card__product-code">Product code: 195434</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="card__product-code">Product code: 195434</div>
<p class="card__product-code">Product code: 195434</p>


<div class="card__reviews">
<div class="card__review-stars stars stars--1">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="card__review-stars stars stars--1">
<div class="card__review-stars stars stars--4">

<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="card__reviews-reviews">Reviews: 5</div>
<p class="card__reviews-reviews">Reviews: 5</p>

</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>
<p class="card__price">
<span class="card__price-how">Price</span>
<span class="card__price-what">$2.199</span>
</p>


<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
<div
class="card"
data-qa="card"
>
<div class="card__title">
APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
</div>

<div class="card__product-code">Product code: 195434</div>

<div class="card__reviews">
<div class="card__review-stars stars stars--1">
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
<div class="stars__star"></div>
</div>

<div class="card__reviews-reviews">Reviews: 5</div>
</div>

<div class="card__price">
<div class="card__price-how">Price</div>
<div class="card__price-what">$2.199</div>
</div>

<div class="card__buy">
<button
class="card__buy-button"
data-qa="card-hover"
>
buy
</button>
</div>
</div>
</main>
</body>
</html>
Loading
Loading