Catalog #4906

TaniaP26 · 2024-12-07T07:33:40Z

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

src/index.html
src/styles/blocks/cards.scss
src/styles/blocks/header.scss
src/styles/blocks/stars.scss
src/styles/index.scss
src/utils/mixins.scss
src/utils/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

src/index.html
src/styles/blocks/cards.scss
src/styles/blocks/header.scss
src/styles/blocks/stars.scss
src/styles/index.scss
src/utils/mixins.scss
src/utils/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

src/index.html
src/styles/blocks/cards.scss
src/styles/blocks/header.scss
src/styles/blocks/stars.scss
src/styles/index.scss
src/utils/mixins.scss
src/utils/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

mateacademy-ai-mentor

Sorry, the pull request review was unsuccessful for the following reasons:

Warning

There are no files to review. Please make sure that you have added files to the pull request. Some files and directories may be ignored from the review or failed to load.
_{[CODE: 4]}

Additional info:
Ignored files list:

src/index.html
src/styles/blocks/cards.scss
src/styles/blocks/header.scss
src/styles/blocks/stars.scss
src/styles/index.scss
src/utils/mixins.scss
src/utils/variables.scss

If the issue is within your control, please address it.
The next review attempt will automatically launch in 1 hour.
If you believe this is an error or need assistance, please contact the support team.

anastasiiavorobiova

Great work!
Consider fixing styles to pass tests

anastasiiavorobiova · 2024-12-07T13:39:33Z

src/index.html

+        <div class="card__title">
+          APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
+        </div>


Suggested change

<div class="card__title">

APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)

</div>

<h3 class="card__title">

APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)

</h3>

Consider leveraging semantic tags

anastasiiavorobiova · 2024-12-07T13:39:41Z

src/index.html

+          APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
+        </div>
+
+        <div class="card__product-code">Product code: 195434</div>


Suggested change

<div class="card__product-code">Product code: 195434</div>

<p class="card__product-code">Product code: 195434</p>

anastasiiavorobiova · 2024-12-07T13:39:48Z

src/index.html

+        <div class="card__product-code">Product code: 195434</div>
+
+        <div class="card__reviews">
+          <div class="card__review-stars stars stars--1">


Suggested change

<div class="card__review-stars stars stars--1">

<div class="card__review-stars stars stars--4">

anastasiiavorobiova · 2024-12-07T13:39:54Z

src/index.html

+            <div class="stars__star"></div>
+          </div>
+
+          <div class="card__reviews-reviews">Reviews: 5</div>


Suggested change

<div class="card__reviews-reviews">Reviews: 5</div>

<p class="card__reviews-reviews">Reviews: 5</p>

anastasiiavorobiova · 2024-12-07T13:40:15Z

src/index.html

+        <div class="card__price">
+          <div class="card__price-how">Price</div>
+          <div class="card__price-what">$2.199</div>
+        </div>


Suggested change

<div class="card__price">

<div class="card__price-how">Price</div>

<div class="card__price-what">$2.199</div>

</div>

<p class="card__price">

<span class="card__price-how">Price</span>

<span class="card__price-what">$2.199</span>

</p>

anastasiiavorobiova · 2024-12-07T13:41:37Z

src/styles/blocks/cards.scss

+    }
+
+    &--button:hover {
+      background-color: #fff;


Consider using a variable here

anastasiiavorobiova · 2024-12-07T13:42:59Z

src/styles/blocks/header.scss

+    }
+  }
+
+  li:first-child a {


Suggested change

li:first-child a {

&__item:first-child &__link {

anastasiiavorobiova · 2024-12-07T13:44:20Z

src/styles/blocks/stars.scss

+  margin-right: 0;
+}
+
+.stars--1 .stars__star:nth-child(-n + 1) {


Suggested change

.stars--1 .stars__star:nth-child(-n + 1) {

.stars--1 .stars__star:nth-child(-n + 1),

.stars--2 .stars__star:nth-child(-n + 2),

.stars--3 .stars__star:nth-child(-n + 3),

.stars--4 .stars__star:nth-child(-n + 4),

.stars--5 .stars__star:nth-child(-n + 5) {

anastasiiavorobiova · 2024-12-07T13:44:30Z

src/styles/blocks/stars.scss

+.stars--2 .stars__star:nth-child(-n + 2) {
+  background-image: url(../images/star-active.svg);
+}
+
+.stars--3 .stars__star:nth-child(-n + 3) {
+  background-image: url(../images/star-active.svg);
+}
+
+.stars--4 .stars__star:nth-child(-n + 4) {
+  background-image: url(../images/star-active.svg);
+}
+
+.stars--5 .stars__star:nth-child(-n + 5) {
+  background-image: url(../images/star-active.svg);
+}


Suggested change

.stars--2 .stars__star:nth-child(-n + 2) {

background-image: url(../images/star-active.svg);

}

.stars--3 .stars__star:nth-child(-n + 3) {

background-image: url(../images/star-active.svg);

}

.stars--4 .stars__star:nth-child(-n + 4) {

background-image: url(../images/star-active.svg);

}

.stars--5 .stars__star:nth-child(-n + 5) {

background-image: url(../images/star-active.svg);

}

anastasiiavorobiova · 2024-12-07T13:45:07Z

src/index.html

@@ -23,5 +23,380 @@

  <body>
    <h1>Catalog</h1>


Suggested change

<h1>Catalog</h1>

volodymyr-soltys97

Good job!
Let's improve your code
Cards should shrink as smoothly as they grow.
Also, you need to fix all comments from the previous review

volodymyr-soltys97 · 2024-12-07T18:41:57Z

src/index.html

@@ -23,5 +23,380 @@

  <body>
    <h1>Catalog</h1>


volodymyr-soltys97 · 2024-12-07T18:43:05Z

src/index.html

+        <div class="card__title">
+          APPLE A1419 iMac 27" Retina 5K Monoblock (MNED2UA/A)
+        </div>


anastasiiavorobiova

Consider fixing previous comments

volodymyr-soltys97

Hi, the comments from the previous review still not fixed, you need to fix all comments and make deploy again after your changes

etojeDenys · 2024-12-09T20:16:11Z

src/styles/blocks/stars.scss

+.stars {
+  display: flex;
+}
+
+.stars__star {


Suggested change

.stars {

display: flex;

}

.stars__star {

.stars {

display: flex;

&__star {

........

you should use nesting

Catalog

1d57965

mateacademy-ai-mentor reviewed Dec 7, 2024

View reviewed changes

anastasiiavorobiova suggested changes Dec 7, 2024

View reviewed changes

TaniaP26 requested a review from mateacademy-ai-mentor December 7, 2024 16:54

volodymyr-soltys97 suggested changes Dec 7, 2024

View reviewed changes

TaniaP26 requested review from volodymyr-soltys97 and anastasiiavorobiova December 7, 2024 20:33

anastasiiavorobiova suggested changes Dec 8, 2024

View reviewed changes

TaniaP26 requested a review from anastasiiavorobiova December 8, 2024 14:27

volodymyr-soltys97 suggested changes Dec 9, 2024

View reviewed changes

Catalog fixed

7a7bb9a

TaniaP26 requested a review from volodymyr-soltys97 December 9, 2024 17:51

etojeDenys approved these changes Dec 9, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Catalog #4906

Catalog #4906

TaniaP26 commented Dec 7, 2024

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

mateacademy-ai-mentor left a comment

anastasiiavorobiova left a comment

anastasiiavorobiova Dec 7, 2024

volodymyr-soltys97 Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

anastasiiavorobiova Dec 7, 2024

volodymyr-soltys97 Dec 7, 2024

volodymyr-soltys97 left a comment

volodymyr-soltys97 Dec 7, 2024

volodymyr-soltys97 Dec 7, 2024

anastasiiavorobiova left a comment

volodymyr-soltys97 left a comment

etojeDenys Dec 9, 2024

TaniaP26 Dec 9, 2024

	<div class="card__product-code">Product code: 195434</div>
	<p class="card__product-code">Product code: 195434</p>

	<div class="card__review-stars stars stars--1">
	<div class="card__review-stars stars stars--4">

	<div class="card__reviews-reviews">Reviews: 5</div>
	<p class="card__reviews-reviews">Reviews: 5</p>

-.stars--1 .stars__star:nth-child(-n + 1) {
+.stars--1 .stars__star:nth-child(-n + 1),
+.stars--2 .stars__star:nth-child(-n + 2),
+.stars--3 .stars__star:nth-child(-n + 3),
+.stars--4 .stars__star:nth-child(-n + 4),
+.stars--5 .stars__star:nth-child(-n + 5) {

Catalog #4906

Are you sure you want to change the base?

Catalog #4906

Conversation

TaniaP26 commented Dec 7, 2024

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

anastasiiavorobiova left a comment

Choose a reason for hiding this comment

volodymyr-soltys97 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment