Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added solution #1281

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/main/java/core/basesyntax/Application.java
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,12 @@
public class Application {
public static void main(String[] args) {
// create three balls using class Lottery and print information about them in console
Lottery ballOne = new Lottery();
Lottery ballTwo = new Lottery();
Lottery ballThree = new Lottery();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lottery is lottery, Ball is ball. We need 1 Lottery and 3 Balls


System.out.println(ballOne.getRandomBall().toString());
System.out.println(ballTwo.getRandomBall().toString());
System.out.println(ballThree.getRandomBall().toString());
}
}
30 changes: 30 additions & 0 deletions src/main/java/core/basesyntax/Ball.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
package core.basesyntax;

public class Ball {

private String color;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Enum Color that you created instead of regular String

private int number;

public String getColor() {
return color;
}

public void setColor(String color) {
this.color = color;
}

public int getNumber() {
return number;
}

public void setNumber(int number) {
this.number = number;
}

@Override
public String toString() {
return "Ball: "
+ "color - " + color
+ "; number - " + number;
}
}
7 changes: 6 additions & 1 deletion src/main/java/core/basesyntax/ColorSupplier.java
Original file line number Diff line number Diff line change
@@ -1,7 +1,12 @@
package core.basesyntax;

import java.util.Random;

public class ColorSupplier {
public String getRandomColor() {
return null;
Random random = new Random();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Colors[] colors = Colors.values();
int indexOfRandom = random.nextInt(colors.length);
return colors[indexOfRandom].toString();
}
}
10 changes: 10 additions & 0 deletions src/main/java/core/basesyntax/Colors.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
package core.basesyntax;

public enum Colors {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
public enum Colors {
public enum Color {

RED,
WHITE,
BLACK,
GREEN,
BLUE,
ORANGE;
}
18 changes: 18 additions & 0 deletions src/main/java/core/basesyntax/Lottery.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package core.basesyntax;

import java.util.Random;

public class Lottery {

Ball getRandomBall() {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add access modifier for this method

Ball ball = new Ball();

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move Ball, Color and Random instances creation out of this method - create them at the class level, so they can be reusable. Don't foerget access modifier for these fields once they are at the class level

private Ball ball = new Ball();

public Ball getRandomBall() {
...
}

ColorSupplier colorSupplier = new ColorSupplier();
String color = colorSupplier.getRandomColor();
ball.setColor(color);

Random random = new Random();
int ballIndex = random.nextInt(101);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

ball.setNumber(ballIndex);
return ball;
}
}
Loading