added solution #1281
added solution #1281
Conversation
| Lottery ballOne = new Lottery(); | ||
| Lottery ballTwo = new Lottery(); | ||
| Lottery ballThree = new Lottery(); |
There was a problem hiding this comment.
Lottery is lottery, Ball is ball. We need 1 Lottery and 3 Balls
| public class Ball { | ||
|
|
||
| private String color; |
| @@ -0,0 +1,10 @@ | |||
| package core.basesyntax; | |||
|
|
|||
| public enum Colors { | |||
There was a problem hiding this comment.
| public enum Colors { | |
| public enum Color { |
| public class ColorSupplier { | ||
| public String getRandomColor() { | ||
| return null; | ||
| Random random = new Random(); |
| package core.basesyntax; | ||
|
|
||
| public class Ball { | ||
| private String color; |
There was a problem hiding this comment.
Use Enum Color that you created instead of regular String
|
|
||
| public class Lottery { | ||
|
|
||
| Ball getRandomBall() { |
There was a problem hiding this comment.
Add access modifier for this method
| System.out.println(lottery.getRandomBall().toString()); | ||
| System.out.println(lottery.getRandomBall().toString()); | ||
| System.out.println(lottery.getRandomBall().toString()); |
There was a problem hiding this comment.
Use for loop for the repeatable actions. It's the same logic as you have in checklist for this task - "Use for loop for creating several objects of the same class"
| public class Lottery { | ||
|
|
||
| Ball getRandomBall() { | ||
| Ball ball = new Ball(); |
There was a problem hiding this comment.
Move Ball, Color and Random instances creation out of this method - create them at the class level, so they can be reusable. Don't foerget access modifier for these fields once they are at the class level
private Ball ball = new Ball();
public Ball getRandomBall() {
...
}
| ball.setColor(color); | ||
|
|
||
| Random random = new Random(); | ||
| int ballIndex = random.nextInt(101); |
- Optimized Lottery - Added loops in Application - Added access modifiers
No description provided.