Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

solution #1821

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 24 additions & 3 deletions src/herbivoresAndCarnivores.js
Original file line number Diff line number Diff line change
@@ -1,15 +1,36 @@
'use strict';

class Animal {
// write your code here
static alive = [];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#952 (comment)
You can add static property as in issue comment to avoid test fails

Suggested change
static alive = [];

constructor(name, health = 100) {
this.name = name;
this.health = health;
Animal.alive.push(this);
}
}

class Herbivore extends Animal {
// write your code here
constructor(name, health) {
super(name, health);
this.hidden = false;
}
hide() {
this.hidden = true;
}
}

class Carnivore extends Animal {
// write your code here
bite(animal) {
if (animal instanceof Herbivore && !animal.hidden) {
animal.health -= 50;
}

if (animal.health === 0) {
const index = Animal.alive.indexOf(animal);

Animal.alive.splice(index, 1);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change it to method filter and clear alive array from animals with health <= 0
Move this logic to separated method in instance of Animal class and use it here as method of Animal

}
}
}

module.exports = {
Expand Down