solution #1821
Open
solution #1821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
33Orange
suggested changes
May 31, 2023
src/herbivoresAndCarnivores.js
Outdated
| @@ -1,15 +1,36 @@ | |||
| 'use strict'; | |||
|
|
|||
| class Animal { | |||
| // write your code here | |||
| static alive = []; | |||
There was a problem hiding this comment.
#952 (comment)
You can add static property as in issue comment to avoid test fails
Suggested change
| static alive = []; |
src/herbivoresAndCarnivores.js
Outdated
Comment on lines
29
to
31
| const index = Animal.alive.indexOf(animal); | ||
|
|
||
| Animal.alive.splice(index, 1); |
There was a problem hiding this comment.
Let's change it to method filter and clear alive array from animals with health <= 0
Move this logic to separated method in instance of Animal class and use it here as method of Animal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.