Feature/NR-59 Fix handling steam client html pages errors #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukatarman
commented
Nov 9, 2023
stas-at-ibm
approved these changes
Nov 10, 2023
backend/src/infrastructure/database/repositories/steam.apps.repository.js
Outdated
Show resolved
Hide resolved
backend/src/infrastructure/database/repositories/steam.apps.repository.js
Outdated
Show resolved
Hide resolved
stas-at-ibm
approved these changes
Nov 14, 2023
lukatarman
force-pushed
the
feature/NR-59-fix-handling-steam-client-html-pages-errors
branch
4 times, most recently
from
ec1fb69 to
e70b700
Compare
Added steam client HTTP requests returning empty string on errors Added adding respective client name to a failed property via its steamapp equivalent "triedVia" property Adjusted game service file to reflect these new changes Added getSteamAppsById to steam apps repository Moved ValidDataSources class to models folder Added triedViaSteamDb steamApp class method Added steamDb valid data source Adjusted tests to reflect new code Previously, when html requests to certain apps/games failed due to the webpages errors, our app would fail to run some code and would get stuck in an infinite loop. This should now be fixed. Issue-Ref: #164
lukatarman
force-pushed
the
feature/NR-59-fix-handling-steam-client-html-pages-errors
branch
from
e70b700 to
eae1ad9
Compare
|
This should've been a bugfix which is a patch i.e. the commit message starts with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #164