fixed tests

lukatarman · Dec 6, 2023 · ec1fb69 · ec1fb69
1 parent 5e33d8d
commit ec1fb69
Showing 1 changed file with 22 additions and 55 deletions.
diff --git a/backend/src/features/game-identifier/game.identifier.spec.js b/backend/src/features/game-identifier/game.identifier.spec.js
@@ -26,11 +26,6 @@ describe("game.identifier.js", function () {
   describe(".tryViaSteamWeb", function () {
     describe("gets zero steamApps from the database and stops. So,", function () {
       beforeAll(async function () {
-        this.options = {
-          batchSize: 1,
-          unitDelay: 0,
-        };
-
         this.steamClientMock = createSteamMock([undefined]);
 
         this.steamAppsRepository = createSteamAppsRepositoryMock([], undefined);
@@ -82,7 +77,7 @@ describe("game.identifier.js", function () {
 
     describe("gets one game out of a batch of one steamApp, and inserts it into the database. So,", function () {
       beforeAll(async function () {
-        this.app = [{ appid: 1, name: "Animaddicts" }];
+        this.app = getXSampleSteamApps(1);
 
         this.games = discoverGamesFromSteamWeb(this.app, [
           animaddicts2gameHtmlDetailsPage,
@@ -196,15 +191,7 @@ describe("game.identifier.js", function () {
 
     describe("gets one game out of a batch of two steamApps, and inserts it into the database. So,", function () {
       beforeAll(async function () {
-        this.options = {
-          batchSize: 2,
-          unitDelay: 0,
-        };
-
-        this.apps = [
-          { appid: 1, name: "Animaddicts" },
-          { appid: 2, name: "Glitchhikers Soundtrack" },
-        ];
+        this.apps = getXSampleSteamApps(2);
 
         this.htmlDetailsPages = [
           animaddicts2gameHtmlDetailsPage,
@@ -519,10 +506,7 @@ describe("game.identifier.js", function () {
 
     describe("gets one game from a batch of two steamApps from the database and inserts them into the database. So,", function () {
       beforeAll(async function () {
-        this.apps = [
-          { appid: 1, name: "Elden Ring" },
-          { appid: 2, name: "Swords and Soldiers Beta" },
-        ];
+        this.apps = getXSampleSteamApps(2);
 
         this.htmlDetailsPages = [
           eldenRingHttpDetailsSteamcharts,
@@ -645,11 +629,7 @@ describe("game.identifier.js", function () {
 
     describe("gets two games from a batch of three steamApps from the database and inserts them into the database. So,", function () {
       beforeAll(async function () {
-        this.apps = [
-          { appid: 1, name: "Elden Ring" },
-          { appid: 2, name: "Swords and Soldiers Beta" },
-          { appid: 3, name: "Mortal Darkness" },
-        ];
+        this.apps = getXSampleSteamApps(3);
 
         this.htmlDetailsPages = [
           eldenRingHttpDetailsSteamcharts,
@@ -895,30 +875,22 @@ describe("game.identifier.js", function () {
     describe("Finds four games with missing properties,", function () {
       describe("with the second and third games' pages experiencing an error", function () {
         beforeAll(async function () {
-          this.options = {
-            batchSize: 4,
-            unitDelay: 0,
-          };
-
           this.steamApps = getXSampleSteamApps(4);
 
           this.failedSteamApps = getTwoFailedSteamApps(this.steamApps);
 
           this.gamesRepoReturn = getXGamesWithoutDetails(4);
 
-          this.steamClientMock = createSteamMock([
+          const pagesArray = [
             counterStrikeHtmlDetailsSteamDb,
             "",
             "",
             riskOfRainHtmlDetailsSteamDb,
-          ]);
+          ];
 
-          const htmlPages = createHtmlDetailsPages([
-            counterStrikeHtmlDetailsSteamDb,
-            "",
-            "",
-            riskOfRainHtmlDetailsSteamDb,
-          ]);
+          this.steamClientMock = createSteamMock(pagesArray);
+
+          const htmlPages = createHtmlDetailsPages(pagesArray);
 
           updateMissingDetails(this.gamesRepoReturn, htmlPages);
 
@@ -936,7 +908,7 @@ describe("game.identifier.js", function () {
             this.gamesRepository,
             this.historyChecksRepository,
             createLoggerMock(),
-            this.options,
+            createConfigMock(4).features,
           );
 
           await this.identifier.updateGamesWithoutDetails();
@@ -946,10 +918,8 @@ describe("game.identifier.js", function () {
           expect(this.gamesRepository.getGamesWithoutDetails).toHaveBeenCalledTimes(1);
         });
 
-        it("getGamesWithoutDetails was called with 'this.options.batchSize'", function () {
-          expect(this.gamesRepository.getGamesWithoutDetails).toHaveBeenCalledWith(
-            this.options.batchSize,
-          );
+        it("getGamesWithoutDetails was called with the correct batch size", function () {
+          expect(this.gamesRepository.getGamesWithoutDetails).toHaveBeenCalledWith(4);
         });
 
         it("getGamesWithoutDetails was called before getSteamAppsById", function () {
@@ -1019,7 +989,7 @@ describe("game.identifier.js", function () {
           expect(this.gamesRepository.updateGameDetails).toHaveBeenCalledTimes(1);
         });
 
-        it("updateGameDetails was called with the correct arguments", function () {
+        it("updateGameDetails was called with the correct argument", function () {
           expect(this.gamesRepository.updateGameDetails).toHaveBeenCalledWith(
             this.gamesRepoReturn,
           );
@@ -1052,12 +1022,12 @@ describe("game.identifier.js", function () {
         expect(this.gamesRepository.getGamesWithoutReleaseDates).toHaveBeenCalledTimes(1);
       });
 
-      it("getGamesWithoutDetails was called with the correct batch size", function () {
+      it("getGamesWithoutReleaseDates was called with the correct batch size", function () {
         expect(this.gamesRepository.getGamesWithoutReleaseDates).toHaveBeenCalledWith(2);
       });
 
       it("getSteamAppsById was not called", function () {
-        expect(this.steamAppsRepository.getSteamAppsById).toHaveBeenCalledTimes(1);
+        expect(this.steamAppsRepository.getSteamAppsById).toHaveBeenCalledTimes(0);
       });
 
       it("getSteamDbHtmlDetailsPage was not called", function () {
@@ -1168,21 +1138,18 @@ describe("game.identifier.js", function () {
 
           this.gamesRepoReturn = Game.manyFromDbEntry(getXGamesWithoutDetails(4));
 
-          this.steamClientMock = createSteamMock([
+          const pages = [
             counterStrikeHtmlDetailsSteamDb,
             "",
             "",
             riskOfRainHtmlDetailsSteamDb,
-          ]);
+          ];
 
-          this.failedSteamApps = getTwoFailedSteamApps(this.steamApps);
+          this.steamClientMock = createSteamMock(pages);
 
-          const htmlPages = [
-            { page: counterStrikeHtmlDetailsSteamDb, id: 1 },
-            { page: "", id: 2 },
-            { page: "", id: 3 },
-            { page: riskOfRainHtmlDetailsSteamDb, id: 4 },
-          ];
+          const htmlPages = createHtmlDetailsPages(pages);
+
+          this.failedSteamApps = getTwoFailedSteamApps(this.steamApps);
 
           updateMissingReleaseDates(this.gamesRepoReturn, htmlPages);
 
@@ -1200,7 +1167,7 @@ describe("game.identifier.js", function () {
             this.gamesRepository,
             this.historyChecksRepository,
             createLoggerMock(),
-            createConfigMock(2).features,
+            createConfigMock(4).features,
           );
 
           await this.identifier.updateGamesWithoutReleaseDates();