Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update database relationship diagram #1144

Merged
merged 5 commits into from
Jan 15, 2025
Merged

Update database relationship diagram #1144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7d1dcbc
Update pull_request_template.md
michplunkett Jan 15, 2025
c10807e
Delete database_relationships.July2024.png
michplunkett Jan 15, 2025
4a5e702
Update README.md
michplunkett Jan 15, 2025
cc3e535
Create database_relationships.png
michplunkett Jan 15, 2025
8852d7e
Update pull_request_template.md
michplunkett Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,5 +26,6 @@ dispatcher where…", "Improve our handling of…", etc.

## Tests and Linting
- [ ] This branch is up-to-date with the `develop` branch.
- [ ] The database diagram (`database/database_relationships.png`) has been updated if any database column have been changed, added, or dropped.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This phrasing feels clunky. I'd certainly welcome any recommendations people may have.

- [ ] `pytest` passes on my local development environment.
- [ ] `pre-commit` passes on my local development environment.
2 changes: 1 addition & 1 deletion database/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@
Running `make dev` in the docker environment will create and persist the database.

## Database Diagram
![](database_relationships.July2024.png)
![](database_relationships.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to keep some information about the last time this was updated or changed. I think keeping it in the filename is fine but open to other ways of doing it as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm working on a way to do this with a make command right now. When that's done (within a day or two), when it was last done should no longer be an issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fixed with this PR: #1146

Binary file removed database/database_relationships.July2024.png
View file
Open in desktop
Binary file not shown.
Binary file added database/database_relationships.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading