Update database relationship diagram #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michplunkett
requested review from
b-meson,
AetherUnbound,
abandoned-prototype and
sea-kelp
michplunkett
commented
Jan 15, 2025
| @@ -26,5 +26,6 @@ dispatcher where…", "Improve our handling of…", etc. | |||
|
|
|||
| ## Tests and Linting | |||
| - [ ] This branch is up-to-date with the `develop` branch. | |||
| - [ ] The database diagram (`database/database_relationships.png`) has been updated if any database column have been changed, added, or dropped. | |||
There was a problem hiding this comment.
This phrasing feels clunky. I'd certainly welcome any recommendations people may have.
b-meson
approved these changes
Jan 15, 2025
b-meson
reviewed
Jan 15, 2025
| @@ -4,4 +4,4 @@ | |||
| Running `make dev` in the docker environment will create and persist the database. | |||
|
|
|||
| ## Database Diagram | |||
|  | |||
|  | |||
There was a problem hiding this comment.
It would be nice to keep some information about the last time this was updated or changed. I think keeping it in the filename is fine but open to other ways of doing it as well.
There was a problem hiding this comment.
I'm working on a way to do this with a make command right now. When that's done (within a day or two), when it was last done should no longer be an issue.
There was a problem hiding this comment.
It's fixed with this PR: #1146
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Updated the database relationship diagram to match the current state of the application and added a note to the
pull_request_template.mdfile to make sure it's updated if any changes are made to the database schema.Tests and Linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.