Link real IMM_ROM_EXT into ROM_EXT #25686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchiawei
requested review from
moidx,
a team and
timothytrippel
and removed request for
a team
lchiawei
force-pushed
the
link-main-imm
branch
5 times, most recently
from
3f86086 to
d6eb8e8
Compare
|
@lchiawei could you also rebase this on the latest tip of tree since it has been a few weeks since this was submitted (to prevent merge SKU)? |
|
I think this can be rebased now to fix the merge conflicts. |
lchiawei
force-pushed
the
link-main-imm
branch
from
d6eb8e8 to
24029b5
Compare
Thanks for reviewing my PR, I have rebased my commit chain now. However, the CI seems to be cancelled and we may need to trigger the tests again. |
lchiawei
force-pushed
the
link-main-imm
branch
from
24029b5 to
73c7d07
Compare
* Refine ld and .S file for IMM_ROM_EXT. * Update the hello-world IMM_ROM_EXT to access some data in .data and .bss sections to make sure the startup initialization is implemented correctly. Signed-off-by: Chia-Wei Liu <[email protected]>
Remove calling imm_rom_ext_main in rom_ext_main, and use prebuilt IMM_ROM_EXT instead. Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
from
73c7d07 to
a1a1a44
Compare
* Add mechanism to select corresponding IMM_ROM_EXT sections when building ROM_EXT based on the exec_env * Add a new "none manifest" and skip the signing phase when building binaries if we use the none manifest * Add extra_bazel_features for IMM_ROM_EXT (as what we did for ROM_EXT targets) for code size optimization Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
2 times, most recently
from
2d29fbb to
3613069
Compare
As now we always link IMM_ROM_EXT into ROM_EXT, the address of IMM_ROM_EXT's linker for slot A/B ROM_EXT should be adjusted. Apply similar solution from ROM_EXT's linker scripts on IMM_ROM_EXT ones. Also cleaned up the hello-world ROM code as we do not need them anymore. Signed-off-by: Chia-Wei Liu <[email protected]>
lchiawei
force-pushed
the
link-main-imm
branch
from
3613069 to
35fd45c
Compare
timothytrippel
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does the work about the IMM_ROM_EXT linking, including following commits:
imm_rom_ext_main()inrom_ext_main().exec_env. For silicon creator, also add a new exec_env that does not contain a manifest to skip the signing phase.