Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lowrisc_ibex to lowRISC/ibex@667fd20d #25458

Merged
merged 1 commit into from
Dec 8, 2024

Conversation

nasahlpa
Copy link
Member

@nasahlpa nasahlpa commented Nov 29, 2024

Update code from upstream repository
https://github.com/lowRISC/ibex.git to revision
667fd20d2ede51caececccbcbda3652074424ce2

  • [rtl] Fix non-DSP reset in ibex_counter (Pascal Nasahl)
  • Revert "[rtl] Fix counter reset value on FPGA" (Pascal Nasahl)
  • [rtl] Fix counter reset value on FPGA (Pascal Nasahl)
  • [ci] remove Azure Pipelines (Gary Guo)

@nasahlpa nasahlpa requested review from GregAC and vogelpi November 29, 2024 11:57
@nasahlpa
Copy link
Member Author

CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_counter.sv

This PR touches RTL that is only used in the FPGA configuration. This is okay.

@vogelpi
Copy link
Contributor

vogelpi commented Nov 29, 2024

CHANGE AUTHORIZED: hw/vendor/lowrisc_ibex/rtl/ibex_counter.sv

This PR touches RTL that is only used in the FPGA configuration. This is okay.

@engdoreis
Copy link
Contributor

@nasahlpa the FPGA bitstream is failing, would you mind checking if your changes are causing the error?

@nasahlpa
Copy link
Member Author

nasahlpa commented Dec 6, 2024

@nasahlpa the FPGA bitstream is failing, would you mind checking if your changes are causing the error?

This will be resolved once lowRISC/ibex#2228 is merged.

@vogelpi
Copy link
Contributor

vogelpi commented Dec 6, 2024

I've now merged the other PR in the Ibex repo and you can rebase this one @nasahlpa .

Update code from upstream repository
https://github.com/lowRISC/ibex.git to revision
667fd20d2ede51caececccbcbda3652074424ce2

* [rtl] Fix non-DSP reset in ibex_counter (Pascal Nasahl)
* Revert "[rtl] Fix counter reset value on FPGA" (Pascal Nasahl)
* [rtl] Fix counter reset value on FPGA (Pascal Nasahl)
* [ci] remove Azure Pipelines (Gary Guo)

Signed-off-by: Pascal Nasahl <[email protected]>
@nasahlpa nasahlpa changed the title Update lowrisc_ibex to lowRISC/ibex@54985d21 Update lowrisc_ibex to lowRISC/ibex@667fd20d Dec 6, 2024
@engdoreis engdoreis added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Dec 6, 2024
@nasahlpa nasahlpa removed the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Dec 6, 2024
@engdoreis engdoreis merged commit 7ed46b1 into lowRISC:master Dec 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants