Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sival] Enable high UART baud rates on silicon #23605

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Jun 10, 2024

Thanks to #23379 we can now test high baud rates (1MBd, 1.5Mbd) so we enable this on silicon targets.

It's still disabled on the FPGA which cannot clock high enough to test these.

Thanks to @AlexJones0 for the help debugging.

@jwnrt jwnrt requested a review from pamaury June 10, 2024 13:55
@jwnrt jwnrt requested a review from a team as a code owner June 10, 2024 13:55
@jwnrt jwnrt force-pushed the sival-uart-high-baud-rates branch 2 times, most recently from c462fae to 75d6d19 Compare June 10, 2024 20:10
Copy link
Contributor

@alees24 alees24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, and a very welcome improvement, thanks.

sw/device/tests/uart_baud_rate_test.c Outdated Show resolved Hide resolved
sw/device/tests/uart_baud_rate_test.c Outdated Show resolved Hide resolved
@jwnrt jwnrt force-pushed the sival-uart-high-baud-rates branch from 75d6d19 to 10d450d Compare July 10, 2024 10:36
@jwnrt jwnrt force-pushed the sival-uart-high-baud-rates branch from 10d450d to 1c6a9a5 Compare August 14, 2024 11:20
@jwnrt jwnrt added the CherryPick:master This PR should be cherry-picked to master label Aug 14, 2024
@jwnrt jwnrt merged commit a080e1f into lowRISC:earlgrey_es_sival Nov 18, 2024
30 checks passed
@jwnrt jwnrt deleted the sival-uart-high-baud-rates branch November 18, 2024 12:50
Copy link

Backport failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin master
git worktree add -d .worktree/backport-23605-to-master origin/master
cd .worktree/backport-23605-to-master
git switch --create backport-23605-to-master
git cherry-pick -x 1c6a9a5c4af977ff676ef3f6a8f57b5e206021d0

@github-actions github-actions bot added the Manually CherryPick This PR should be manually cherry picked. label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:master This PR should be cherry-picked to master Manually CherryPick This PR should be manually cherry picked.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants