Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Improve reliability of UART baud rate test #25183

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

jwnrt
Copy link
Contributor

@jwnrt jwnrt commented Nov 18, 2024

The FPGA cannot clock high enough for 1MBd or 1.5MBd, but silicon can.

This change enables a wider range of baud rates and changes how the 1MBd and 1.5MBd are restricted to be better for multitop.

Backport of #23605

@jwnrt jwnrt requested a review from a team as a code owner November 18, 2024 12:54
@jwnrt jwnrt requested review from jon-flatley and removed request for a team November 18, 2024 12:54
@jwnrt jwnrt added the CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0 label Nov 18, 2024
@jwnrt jwnrt force-pushed the backport-23605-to-master branch from f090a0a to 195c47a Compare November 18, 2024 13:06
@jwnrt jwnrt requested a review from engdoreis November 21, 2024 15:53
@jwnrt
Copy link
Contributor Author

jwnrt commented Nov 22, 2024

Hm, it failed in CI. I guess it's still flaky.

@jwnrt jwnrt marked this pull request as draft November 22, 2024 10:25
Signed-off-by: James Wainwright <[email protected]>
(commit is original to earlgrey_1.0.0)
(cherry picked from commit 010023f)
@jwnrt jwnrt force-pushed the backport-23605-to-master branch from 195c47a to a61ba70 Compare November 22, 2024 17:55
@jwnrt jwnrt changed the title [test] Enable high baud rates on silicon [test] Improve reliability of UART baud rate test Nov 22, 2024
@jwnrt jwnrt marked this pull request as ready for review November 25, 2024 13:53
@jwnrt jwnrt merged commit 29d7b87 into lowRISC:master Nov 25, 2024
40 checks passed
@jwnrt jwnrt deleted the backport-23605-to-master branch November 25, 2024 13:53
Copy link

Successfully created backport PR for earlgrey_1.0.0:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CherryPick:earlgrey_1.0.0 This PR should be cherry-picked to earlgrey_1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants