Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): fix data use terms not updating when edited #1606

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

bh-ethz
Copy link
Contributor

@bh-ethz bh-ethz commented Apr 15, 2024

resolves #1604

Inserts the up-to-date data use terms status into the sequence details fetched from silo.

Preview: http://instant-update-data-use-t.loculus.org/

@bh-ethz bh-ethz added the preview Triggers a deployment to argocd label Apr 15, 2024
@bh-ethz bh-ethz force-pushed the instant-update-data-use-terms branch from 4fd074a to 90f2fb2 Compare April 15, 2024 15:31
@bh-ethz bh-ethz changed the title insert current data use terms into fetched seq details and auto-refresh fix(website): fix data use terms not updating when edited Apr 15, 2024
@bh-ethz bh-ethz marked this pull request as ready for review April 15, 2024 15:43
@corneliusroemer
Copy link
Contributor

Nice! Do I understand it correctly that we're anyways loading the data use terms from the backend - so pulling the status as well is very cheap. Looks great!

@corneliusroemer
Copy link
Contributor

I've tested and this works flawlessly! Well done!

@bh-ethz
Copy link
Contributor Author

bh-ethz commented Apr 16, 2024

Do I understand it correctly that we're anyways loading the data use terms from the backend

Exactly, the state is already fetched so there is no extra cost for this :)

@bh-ethz bh-ethz merged commit f0fe1d0 into main Apr 16, 2024
13 checks passed
@bh-ethz bh-ethz deleted the instant-update-data-use-terms branch April 16, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Triggers a deployment to argocd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When manually turning restricted sequence to open, the seq details page still shows restricted
2 participants