Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When manually turning restricted sequence to open, the seq details page still shows restricted #1604

Closed
corneliusroemer opened this issue Apr 15, 2024 · 3 comments · Fixed by #1606
Labels
bug Something isn't working website Tasks related to the web application

Comments

@corneliusroemer
Copy link
Contributor

Repro:

  1. Upload restricted data
  2. Release
  3. After release, change data terms to open
  4. Look at seq details
  5. Observe that even though the tooltip of "data terms" shows open, the text itself is still "RESTRICTED"

Related to #1580, @bh-ethz can you have a look? Is this expected?

image
@corneliusroemer corneliusroemer added website Tasks related to the web application bug Something isn't working labels Apr 15, 2024
@fengelniederhammer
Copy link
Contributor

IMO This is more or less expected. It takes up to a minute until the "OPEN" arrives in SILO. The history is fetched from the loculus backend, so this is up to date immediately.

The last time I checked, the "change data use terms" dialog also showed a message that it might take a bit, until it's updated.

@corneliusroemer
Copy link
Contributor Author

Hmm, maybe works as intended but the intention is a bug then.

Should we not take all the fields for the seq details page from the (fast) backend as opposed to the (slow) LAPIS/SILO? This might require larger changes and not be worth it but it seems a bit unfortunate that we use a slow/out of date API where a fast one would work as well (I can't see technical reasons why we require the LAPIS capabilities when showing data about a single sequence entry).

If we can't find a good technical solution for the delayed update, we at least should somehow indicate on the page that an update is pending.

It should be possible to know for the backend whether a certain sequence is in the process of being updated to silo:
a) query the sequence via silo
b) compare the result to what's in the backend
c) if they disagree, we know that something is pending
d) we can show a banner: "update pending"

@bh-ethz
Copy link
Contributor

bh-ethz commented Apr 15, 2024

#1606 This seems to fix the issue.

I overwrite the sequence details entry from silo with the latest entry in the data use terms history. This also allows me to refresh the page on success and show the result instantly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working website Tasks related to the web application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants