Add libwacom_new_from_builder() #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 3, 2024
|
One difficulty I just realised: Might need to introduce a new struct other than |
whot
force-pushed
the
wip/new_from_match
branch
2 times, most recently
from
6d92529 to
00e23a5
Compare
This is a finer-grained solution than the current libwacom_new_from, particularly for testing. The existing functions are emulated in the behavior depending whether values are set or not.
|
Going to merge this, I think it's a useful (and extensible) API and it makes testing a lot easier. |
whot
added a commit
to whot/libwacom
that referenced
this pull request
May 13, 2024
Fixes: 61907bb ("Add libwacom_new_from_builder to construct a new device (linuxwacom#676)")
whot
added a commit
that referenced
this pull request
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new (and hopefully final)
libwacom_new_from...call. This one takes amatchWacomBuilderobject which can now be constructed and filled by the user. In the future if we need to add further fields we can extend theWacomBuilderwith a setter and have this function still work for us.Notably, see #676 (comment) the builder differentiates between the device name and the match name since those two may not be the same. The behaviour of the builder approach matches the existing approaches we have so the various
libwacom_new_from_functions can be emulated with the new builder approach.Prime motivation here is to be able to test better, I don't think any of our callers will switch since they all use
new_from_path. In particular for the correct loading behaviour in #659.Closes #670